Dev update 20231215

[Tobias-Fischer]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[Tobias-Fischer]

@conda-forge-admin, please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycolmap-feedstock/actions/runs/7215182845.

[Tobias-Fischer]

@conda-forge-admin, please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycolmap-feedstock/actions/runs/7215321687.

[Tobias-Fischer]

Needs conda-forge/colmap-feedstock#30

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycolmap-feedstock/actions/runs/7280748063.

[Tobias-Fischer]

@conda-forge-admin please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycolmap-feedstock/actions/runs/7281139650.

[carterbox]

My general tips are to use the latest CMake CUDA features such as enable_language(CUDA) and/or find_package(CUDAToolkit) (not find_package(CUDA)).

Specifically for this recipe, it doesn't seem like having the CUDA compiler is necessary at all, since there doesn't seem to be any device code in pycolmap, so I'm not sure why your CMakeLists are searching for the CUDA Toolkit. Probably, you can just build one cuda/noncuda variant for each python version because the ABI for all of the CUDA variants of colmap is the same. An example of this is astra-toolbox, where the CUDA variant of this python package links to any of the CUDA builds of libastra.

[Tobias-Fischer]

Thanks @carterbox! Looks like all is green now. I think upstream will soon combine colmap and pycolmap in a single repo anyhow, so I won’t be changing / patching here further.

[jakirkham]

Is there a reason to add both scikit-build & scikit-build-core?

Thought it was one or the other. IIUC scikit-build-core is replacing scikit-build