-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 24.1.2, use pip source to install itself. #121
Conversation
setuptools and wheel are only required to build the package, not at run time.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.07.10.17.49.47
Another option for building pip is to use the wheel published on PyPI. This would remove the host requirement on I have a branch on my fork that implements this if there is interest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jonathan! 🙏
Also nice to see you again 😄
Think this approach is great and we should do it 👍
Had a very minor suggestion below
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jonathan! 🙏
Tidying a couple more things below
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@conda-forge/pip @conda-forge/core The removal of setuptools and wheel is breaking expectations people have had for what they get in the env when they install pip. Do we need to add them back? |
The change was intentional in the bullet points above:
That said, no strong feelings if folks would like to add them back |
Let's move further discussion of this to the open issue for easier tracking: #124 |
Yep. I see that the change was intentional. I am looking for further discussion. Do we want to take the pure path here or go more "batteries included"? AFAIK, we have shipped setuptools+wheel as run deps with pip for ~8 years now (5f1aff6) since this feedstock was created. Given how low this package sits in the typical dev stack, the removal of these deps is definitely non-trivial. |
Could we please move this to the open issue ( #124 )? |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Changes:
setuptools
andwheel
. They are only needed to build the package not at runtime.