Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 24.1.2, use pip source to install itself. #121

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Jul 10, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Changes:

  • Update to version 24.1.2
  • Bump minimum Python version to 3.8. Python 3.7 support was removed in version 24.1.
  • Use the pip source to install itself. Note that setup.py was removed in version 24.1.
  • Remove the run requirements on setuptools and wheel. They are only needed to build the package not at runtime.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jjhelmus
Copy link
Contributor Author

Another option for building pip is to use the wheel published on PyPI. This would remove the host requirement on setuptools and wheel which breaks a dependency cycle.

I have a branch on my fork that implements this if there is interest.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonathan! 🙏

Also nice to see you again 😄

Think this approach is great and we should do it 👍

Had a very minor suggestion below

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonathan! 🙏

Tidying a couple more things below

recipe/build.sh Outdated Show resolved Hide resolved
recipe/bld.bat Outdated Show resolved Hide resolved
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jul 31, 2024
@github-actions github-actions bot merged commit 5dcd8a4 into conda-forge:main Jul 31, 2024
3 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@beckermr
Copy link
Member

@conda-forge/pip @conda-forge/core The removal of setuptools and wheel is breaking expectations people have had for what they get in the env when they install pip. Do we need to add them back?

@jakirkham
Copy link
Member

The change was intentional in the bullet points above:

  • Remove the run requirements on setuptools and wheel. They are only needed to build the package not at runtime.

That said, no strong feelings if folks would like to add them back

@jakirkham
Copy link
Member

Let's move further discussion of this to the open issue for easier tracking: #124

@beckermr
Copy link
Member

beckermr commented Jul 31, 2024

Yep. I see that the change was intentional.

I am looking for further discussion. Do we want to take the pure path here or go more "batteries included"?

AFAIK, we have shipped setuptools+wheel as run deps with pip for ~8 years now (5f1aff6) since this feedstock was created.

Given how low this package sits in the typical dev stack, the removal of these deps is definitely non-trivial.

@jakirkham
Copy link
Member

jakirkham commented Jul 31, 2024

Could we please move this to the open issue ( #124 )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants