Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build legacy comaptibility for windows #96

Closed
wants to merge 6 commits into from
Closed

Build legacy comaptibility for windows #96

wants to merge 6 commits into from

Conversation

conda-forge-linter
Copy link

@conda-forge-linter conda-forge-linter commented May 22, 2022 •
edited by hmaarrfk
Loading

@h-vetinari this comment explains that the legacy bindings are used in cyrptography python
pyca/cryptography#6818 (comment)

@conda-forge-linter conda-forge-linter mentioned this pull request May 22, 2022
Closed
@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Build legacy comaptibility for windows May 22, 2022
@hmaarrfk hmaarrfk marked this pull request as draft May 23, 2022 01:03
@hmaarrfk
Copy link
Contributor

I'm not really sure this did anything. I tried to test locally and it didn't change the results of cryptography

@h-vetinari
Copy link
Member

Should we try merging nevertheless?

@h-vetinari h-vetinari mentioned this pull request May 26, 2022
Closed
@h-vetinari
Copy link
Member

h-vetinari commented May 26, 2022 •
edited
Loading

Should we also add no-module (from this discussion)...?

@hmaarrfk
Copy link
Contributor

Should we try merging nevertheless?

I don't want to merge "a legacy flag" prolonging the delay of incompatibility without a positive effect.

Personally, I don't understand why things are not failing for linux or osx.

Maybe cryptography is gracefully failing there, but not gracefully failing for windows? in which case, we should help them instead of building legacy for windows.

@h-vetinari
Copy link
Member

Maybe cryptography is gracefully failing there, but not gracefully failing for windows? in which case, we should help them instead of building legacy for windows.

The cryptography code you had linked explicitly requires the legacy provider.

Personally, I don't understand why things are not failing for linux or osx.

No idea either, but if the legacy provider is missing, we should build it.

I don't want to merge "a legacy flag" prolonging the delay of incompatibility without a positive effect.

It's not a legacy flag. I'm not sure how closely you followed the OpenSSL 3.0 effort, but a key part was factoring things into pluggable providers. One dogfooding exercise was to put all the cryptographic cruft into a legacy provider that will (on an absurdly long timeline) eventually be removed, but it's still absolutely necessary for feature parity when migrating from OpenSSL 1.1.1 to OpenSSL 3.0.0

@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

Now running into openssl/openssl#18456

@h-vetinari
Copy link
Member

h-vetinari commented Jun 7, 2022 •
edited
Loading

Unclear when 3.0.4 is coming, we should IMO backport openssl/openssl#18446

@h-vetinari h-vetinari mentioned this pull request Jun 15, 2022
Closed
@h-vetinari h-vetinari mentioned this pull request Jun 22, 2022
Merged
@ocefpaf ocefpaf closed this in #99 Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@h-vetinari h-vetinari Awaiting requested review from h-vetinari h-vetinari will be requested when the pull request is marked ready for review h-vetinari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conda-forge-linter @hmaarrfk @h-vetinari @conda-forge-admin