Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activate script POSIX-compatible. #162

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Jun 12, 2024

The activate script can be run in a number of shells, not just bash, so it should only use POSIX-compatible syntax.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks KT!

@beckermr beckermr added the automerge Merge the PR when CI passes label Jun 12, 2024
@timj
Copy link

timj commented Jun 12, 2024

Are we going to get the same problem on line 9 of the script?

@github-actions github-actions bot merged commit 59c4c82 into conda-forge:main Jun 12, 2024
10 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@ktlim
Copy link
Contributor Author

ktlim commented Jun 13, 2024

Oops, I moved too fast. @timj you should have pushed an additional fix before the bot got to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants