Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate HDF5 1.14.3 + libnetcdf 4.9.2 #43

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Conversation

akrherz
Copy link
Contributor

@akrherz akrherz commented May 25, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Would like to see if a simple rerender can build. I have a suspicion that a zlib requirement is needed.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] and others added 2 commits May 25, 2023 14:12
@akrherz akrherz changed the title bump build number migrate HDF5 1.14.0 + libnetcdf 4.9.1 May 25, 2023
@akrherz
Copy link
Contributor Author

akrherz commented May 25, 2023

simple rerender build was green, gonna try to apply the libnetcdf 4.9.1 migration along with HDF5 1.14.0 and see what happens.

conda-forge-webservices[bot] and others added 2 commits May 25, 2023 14:40
@akrherz
Copy link
Contributor Author

akrherz commented May 25, 2023

@conda-forge-admin, please rerender

@akrherz
Copy link
Contributor Author

akrherz commented May 25, 2023

That seemed to have helped, now we are add a test failue

10/18 Test #10: cxx4_test_filter .................***Failed

@xylar
Copy link
Contributor

xylar commented Jun 28, 2023

@akrherz, I think @akrherz, we can't update hdf5 because of this PR. This will jam up downsteam work. any update?

@akrherz
Copy link
Contributor Author

akrherz commented Jun 28, 2023

I didn't get a response on Unidata/netcdf-cxx4#132, so am unsure if we should just skip the test or ?

@xylar
Copy link
Contributor

xylar commented Jun 28, 2023

For what it's worth, the only children seem to be pytrilinos, trilinos.

@xylar
Copy link
Contributor

xylar commented Jun 28, 2023

At least in the hdf5 migration. If Trilinos folks want to get involved, that would be fine. If not, that's fine, too, and we can let the is be until we hear from NCAR/UCAR.

@akrherz
Copy link
Contributor Author

akrherz commented Jan 4, 2024

@conda-forge-admin please rerender

@akrherz
Copy link
Contributor Author

akrherz commented Jan 4, 2024

Whoa @xylar , look at what happened here! appears the latest libnetcdf and latest hdf5 make this happy.

@akrherz akrherz changed the title migrate HDF5 1.14.0 + libnetcdf 4.9.1 migrate HDF5 1.14.3 + libnetcdf 4.9.2 Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/netcdf-cxx4-feedstock/actions/runs/7412352307.

@xylar
Copy link
Contributor

xylar commented Jan 4, 2024

Okay, great! Let's merge!

@akrherz
Copy link
Contributor Author

akrherz commented Jan 4, 2024

Thanks @xylar , I have no such powers with this repo :)

@xylar
Copy link
Contributor

xylar commented Jan 4, 2024

Ah, of course!

@xylar xylar merged commit 32d7c85 into conda-forge:main Jan 4, 2024
11 checks passed
@xylar xylar mentioned this pull request Jan 4, 2024
@akrherz akrherz deleted the rerender branch January 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants