Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 3.8.5 #12

Merged
merged 8 commits into from
Mar 17, 2022
Merged

update to 3.8.5 #12

merged 8 commits into from
Mar 17, 2022

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Apr 4, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@wolfv
Copy link
Member Author

wolfv commented Apr 4, 2021

@hadim @johanneskoester @mariusvniekerk opinions? Not sure about the implications except that maven 3.8.1 requires java 7.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member

hadim commented Apr 5, 2021

I am not using maven either java much anymore so I don't feel very confident reviewing this PR. I can merge it if you are confident enough on your side. Can you maybe remove me from the maintainer list? And add yourself if you want to?

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@wolfv did you want to maintain this?

@hmaarrfk
Copy link
Contributor

This might be necessary for conda-forge/imagemagick-feedstock#218

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-admin please restart cis

conda-forge-webservices[bot] and others added 2 commits March 13, 2022 23:12
@hmaarrfk hmaarrfk changed the title update to 3.8.1 update to 3.8.5 Mar 13, 2022
@hmaarrfk
Copy link
Contributor

Not sure why it is not being found :/

@mariusvniekerk
Copy link
Member

Why is this switching to a src release?

@hmaarrfk
Copy link
Contributor

I think they are doing something to change the SHA on the fly. I was just trying to get it download...

@hmaarrfk hmaarrfk closed this Mar 16, 2022
@hmaarrfk hmaarrfk reopened this Mar 16, 2022
@hmaarrfk hmaarrfk merged commit 5320da9 into conda-forge:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants