Update for CUDA 12.8.0 #33

adibbley · 2025-01-23T20:09:12Z

conda-forge-admin · 2025-01-23T20:13:30Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13016619362. Examine the logs at this URL for more detail.}

adibbley · 2025-01-23T22:31:39Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2025.01.23.20.59.37

adibbley · 2025-01-23T22:46:47Z

@conda-forge-admin, please restart ci

conda-forge-admin · 2025-01-23T23:09:49Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

adibbley · 2025-01-24T22:01:57Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2025.01.24.17.08.54

jakirkham · 2025-01-25T00:20:37Z

Seeing the following error on CI (also attached log for posterity)

+ /home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/x86_64-conda-linux-gnu-gcc -I/home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/targets/x86_64-linux/include -L/home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/targets/x86_64-linux/lib -lcublas /home/conda/recipe_root/test.c
Compiler: $PREFIX/bin/x86_64-conda-linux-gnu-gcc
/home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/targets/x86_64-linux/lib/libcublasLt.so.12: undefined reference to `log2f@GLIBC_2.27'
/home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/libcublas_1737758744897/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/targets/x86_64-linux/lib/libcublasLt.so.12: undefined reference to `__cxa_thread_atexit_impl@GLIBC_2.18'

Looks like Linux x86_64 needs GLIBC 2.28

jakirkham · 2025-01-25T00:26:49Z

Was wondering why we don't see the same error on Linux aarch64. However it looks like we are using this workaround

libcublas-feedstock/recipe/meta.yaml

Line 115 in 79f18e0

    
           - sysroot_linux-aarch64 2.28  # [aarch64] # needed to compile test.c for aarch64 as some symbols are introduced in glibc 2.27

vyasr · 2025-01-25T01:01:28Z

Should we be setting the c stdlib version in the CBC then? The file is pretty empty right now.

jakirkham · 2025-01-25T01:14:25Z

We need to make several changes here. Unfortunately need to call it for the day. We will need to pick this up Monday

jakirkham · 2025-01-27T20:24:03Z

Submitted fixes in PR: #34

These are against CUDA 12.6. Once those go in, we can make one line change to conda_build_config.yaml and re-render

conda-forge-admin · 2025-01-28T17:56:23Z

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

jakirkham · 2025-01-28T17:57:54Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2025.01.28.04.06.09

jakirkham

Merged the aforementioned GLIBC fixes in PR: #34

Have merged in the latest from main into this PR and resolved conflicts

Bumped Linux x86_64's GLIBC version to 2.28 based on our observations above (please see comments below for details). Also re-rendered to propagate this info through

This should fix the test failure we saw before unblocking this PR

jakirkham · 2025-01-28T18:07:33Z

recipe/conda_build_config.yaml

@@ -2,4 +2,4 @@ arm_variant_type: # [aarch64]
  - sbsa          # [aarch64]
 c_stdlib_version:  # [linux]
  - 2.28           # [linux and aarch64]
-  - 2.17           # [linux and x86_64]
+  - 2.28           # [linux and x86_64]


Have set Linux x86_64 to use GLIBC 2.28 based on our observations above: #33 (comment)

jakirkham · 2025-01-28T18:08:31Z

.ci_support/linux_64_.yaml

@@ -5,7 +5,7 @@ c_compiler_version:
 c_stdlib:
 - sysroot
 c_stdlib_version:
- '2.17'
+- '2.28'


Can now see GLIBC 2.28 is used after a re-render

jakirkham · 2025-01-28T18:08:59Z

recipe/meta.yaml


 build:
-  number: 1
+  number: 0


Reset the build/number as it was bumped in the previous PR

Update for CUDA 12.8.0

503d185

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.3, and co…

359be23

…nda-forge-pinning 2025.01.23.20.59.37

conda-forge-webservices bot closed this Jan 23, 2025

conda-forge-webservices bot reopened this Jan 23, 2025

adibbley marked this pull request as ready for review January 23, 2025 22:47

adibbley requested a review from a team as a code owner January 23, 2025 22:47

adibbley added the automerge Merge the PR when CI passes label Jan 23, 2025

adibbley removed the automerge Merge the PR when CI passes label Jan 23, 2025

adibbley marked this pull request as draft January 23, 2025 23:12

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…

fc12ea9

…nda-forge-pinning 2025.01.24.17.08.54

adibbley marked this pull request as ready for review January 24, 2025 22:13

adibbley added the automerge Merge the PR when CI passes label Jan 24, 2025

Merge conda-forge/main into adibbley/cuda-12.8.0

1a94a57

conda-forge-curator bot removed the automerge Merge the PR when CI passes label Jan 28, 2025

jakirkham added 2 commits January 28, 2025 09:56

Reset build/number to 0

b186930

On Linux x86_64 use GLIBC 2.28

40e4959

MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…

6c8a5b5

…nda-forge-pinning 2025.01.28.04.06.09

jakirkham reviewed Jan 28, 2025

View reviewed changes

adibbley added the automerge Merge the PR when CI passes label Jan 28, 2025

conda-forge-admin merged commit 7f3ccae into conda-forge:main Jan 28, 2025
6 checks passed

jakirkham mentioned this pull request Jan 28, 2025

cusparselt v0.7.0.0 conda-forge/cusparselt-feedstock#52

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for CUDA 12.8.0 #33

Update for CUDA 12.8.0 #33

adibbley commented Jan 23, 2025

conda-forge-admin commented Jan 23, 2025 •

edited

Loading

adibbley commented Jan 23, 2025

adibbley commented Jan 23, 2025

conda-forge-admin commented Jan 23, 2025 •

edited

Loading

adibbley commented Jan 24, 2025

jakirkham commented Jan 25, 2025

jakirkham commented Jan 25, 2025

vyasr commented Jan 25, 2025

jakirkham commented Jan 25, 2025

jakirkham commented Jan 27, 2025 •

edited

Loading

conda-forge-admin commented Jan 28, 2025

jakirkham commented Jan 28, 2025

jakirkham left a comment

jakirkham Jan 28, 2025

jakirkham Jan 28, 2025

jakirkham Jan 28, 2025

Update for CUDA 12.8.0 #33

Update for CUDA 12.8.0 #33

Conversation

adibbley commented Jan 23, 2025

conda-forge-admin commented Jan 23, 2025 • edited Loading

adibbley commented Jan 23, 2025

adibbley commented Jan 23, 2025

conda-forge-admin commented Jan 23, 2025 • edited Loading

adibbley commented Jan 24, 2025

jakirkham commented Jan 25, 2025

jakirkham commented Jan 25, 2025

vyasr commented Jan 25, 2025

jakirkham commented Jan 25, 2025

jakirkham commented Jan 27, 2025 • edited Loading

conda-forge-admin commented Jan 28, 2025

jakirkham commented Jan 28, 2025

jakirkham left a comment

Choose a reason for hiding this comment

jakirkham Jan 28, 2025

Choose a reason for hiding this comment

jakirkham Jan 28, 2025

Choose a reason for hiding this comment

jakirkham Jan 28, 2025

Choose a reason for hiding this comment

conda-forge-admin commented Jan 23, 2025 •

edited

Loading

conda-forge-admin commented Jan 23, 2025 •

edited

Loading

jakirkham commented Jan 27, 2025 •

edited

Loading