Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libpnetcdf to requirements #200

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 30, 2024

This prevents #199 in the coming versions. Old versions should be patched in https://github.com/conda-forge/conda-forge-repodata-patches-feedstock.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@njzjz
Copy link
Member Author

njzjz commented Jun 30, 2024

@conda-forge-admin rerender

conda-forge-webservices[bot] and others added 3 commits June 30, 2024 22:13
@njzjz
Copy link
Member Author

njzjz commented Jun 30, 2024

@conda-forge-admin rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/lammps-feedstock/actions/runs/9735709943.

@njzjz
Copy link
Member Author

njzjz commented Jul 1, 2024

Oh I notice the disscusion in #198. I will revert the changes for stdlib and leave the changes in other PRs.

@njzjz
Copy link
Member Author

njzjz commented Jul 1, 2024

@conda-forge-admin rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@jan-janssen
Copy link
Member

@njzjz thanks a lot for taking care of this.

@jan-janssen jan-janssen merged commit 3134664 into conda-forge:main Jul 1, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants