-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitarray test slow #23
Comments
Shouldn't take much more than a minute on Julia 0.5 - https://travis-ci.org/JuliaLang/julia/jobs/275261992#L1823 Something about the way things are built here may be resulting in a serious performance regression. |
Are there any important options that we should be providing? Do we need to explicitly add |
Does the conda build environment set variables like CFLAGS, CXXFLAGS to any default values? Those might be overriding the settings in the Julia build system. |
Yes we set these. What should we be looking to add? |
What are they set to? Julia will set some defaults (I forget whether it's O2 or O3, would have to check the makefiles), but if they are set to something different in the environment it'll use that value. |
Just |
More details are here. Yes we are not adding any optimizations by default. That is too hairy. Best to be dealt with on a per package basis. |
Any more details on what sort of flags should be added? |
TBH if I run this test locally with our
Though I would not be surprised if the test is highly demanding and is causing the CI worker to freeze. Is there some way we can make this test better behaved? If not, I'm leaning towards skipping it as this is slowing down development of the recipe. |
It can also depend on which tests run in the same test worker. |
Build Julia in a totally clean environment from a clone and make. Use the same options that does. Probably does O2 or O3 most places. |
Closing this, reopen if more discussion is needed. bitarray is still a bit slow, but we improved things by forcing the tests to run in parallel in the #157 |
Frequently the
bitarray
test takes too long to complete on the CIs. A sample build log is linked below. Is there something we can do to fix this? Should we just skip it?ref: https://circleci.com/gh/conda-forge/julia-feedstock/62
The text was updated successfully, but these errors were encountered: