Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch rebuild #127

Closed
wants to merge 4 commits into from
Closed

arch rebuild #127

wants to merge 4 commits into from

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Aug 16, 2022 •
edited
Loading

Fixes #125

(I will also try to explain the steps for @hawkinsp below, also added you as a contributor to my fork, but feel free to start your own separate following my initial points here --- I am also happy if you'd like to add yourself to the maintainers here, a bot command will trigger a PR @conda-forge-admin, please add user @username)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam
Copy link
Contributor Author

ngam commented Aug 16, 2022 •
edited
Loading

In 1d3d5f2, I simply modified the a fundamental file to instruct it to add aarch and ppc and use default settings. These defaults sometimes change, but we will see if it will be emulation or cross-compilation. (I can't know from memory.).

Then, instead of "rerendering" locally, we could just call it to rerender here like below:

@conda-forge-admin, please rerender.

This triggers a github action: https://github.com/conda-forge/jaxlib-feedstock/actions/runs/2864558941 that essentially does conda smithy rerender. Note jaxlib (as well as tensorflow) are some of the more annoyingly lengthy rerendering --- approx 15 mins. Most other feedstocks take like a minute or two.

Here, I didn't have to modify much (yet) because we are already cross-compiling for osx-arm64, and those settings carry over, so we should be covered generally. We will likely need to edit the build.sh file soon, once we recognize where it errors...

@ngam ngam mentioned this pull request Aug 16, 2022
Open
1 task
@ngam
Copy link
Contributor Author

ngam commented Aug 16, 2022 •
edited
Loading

They default seems to be travis these days. We have our error(s). Same for both ppc and aarch.

ERROR: /home/conda/feedstock_root/build_artifacts/jaxlib_1660613310262/_build_env/share/bazel/4f8bf64fd1fb810033b876032dab1c49/external/bazel_tools/tools/zip/BUILD:11:1: indentation error
1069ERROR: /home/conda/feedstock_root/build_artifacts/jaxlib_1660613310262/_build_env/share/bazel/4f8bf64fd1fb810033b876032dab1c49/external/bazel_tools/tools/zip/BUILD:14:2: Trailing comma is allowed only in parenthesized tuples.
1070ERROR: /home/conda/feedstock_root/build_artifacts/jaxlib_1660613310262/_build_env/share/bazel/4f8bf64fd1fb810033b876032dab1c49/external/bazel_tools/tools/zip/BUILD:14:3: syntax error at 'outdent': expected expression
1071WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/081771d4a0e9d7d3aa0eed2ef389fa4700dfb23e.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
1072ERROR: /home/conda/feedstock_root/build_artifacts/jaxlib_1660613310262/work/build/BUILD.bazel:38:10: every rule of type py_binary implicitly depends upon the target '@bazel_tools//tools/zip:zipper', but this target could not be found because of: no such target '@bazel_tools//tools/zip:zipper': target 'zipper' not declared in package 'tools/zip' defined by /home/conda/feedstock_root/build_artifacts/jaxlib_1660613310262/_build_env/share/bazel/4f8bf64fd1fb810033b876032dab1c49/external/bazel_tools/tools/zip/BUILD
1073ERROR: Analysis of target '//build:build_wheel' failed; build aborted: Analysis failed
1074INFO: Elapsed time: 58.535s
1075INFO: 0 processes.
1076FAILED: Build did NOT complete successfully (46 packages loaded, 141 targets configured)
1077ERROR: Build failed. Not running target
1078FAILED: Build did NOT complete successfully (46 packages loaded, 141 targets configured)
1079

To save bandwidth and to help us run things more clearly, I am going to disable all builds except for python3.10 ppc/aarch openssl1.1.1

@ngam ngam changed the title add aarch support arch rebuild Aug 16, 2022
@ngam
Copy link
Contributor Author

ngam commented Aug 16, 2022

Cross-compilation companion: #128

@ngam
Copy link
Contributor Author

ngam commented Aug 16, 2022

xref: jax-ml/jax#9653

@ngam ngam closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmjl ericmjl Awaiting requested review from ericmjl ericmjl will be requested when the pull request is marked ready for review ericmjl is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy will be requested when the pull request is marked ready for review xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Add support for Linux ARM64
2 participants
@ngam @conda-forge-linter