-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
szip support with libaec doesn't work with hdf5 =1.14.1 #207
Comments
Here's a small test that could be added based on @mkitti previous work #197 (comment)
|
I suspect this is a fixed upstream issue |
develop branch fix HDFGroup/hdf5#3035 |
I think this may be fixed by 1.14.2: |
hmm, sorry, i think i just forgot to re-include it. often these build patches get merged upstream quickly and i must have wrongly assumed. Are you able to verify that including the patch fixes things on windows? |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I just wanted to let you know that I started rerendering the recipe in #208. |
My understanding is that patch appears to have been incorporated upstream. It is unclear if we need to modify the configuration in response. |
Is there a way to me to test the newly built package ? It has not been pushed to the channel yet and I don't know if there is a way to get hold of the built artifact. |
your example is with h5py. it is dependent on the patch version of hdf5, so you will have to wait for h5py to be rebuilt. |
Ok I see it now. Pretty narrow version limiting. However I also see you as the maintainer 😊 |
one of them..... mkitti actually understand the ins and outs of the library.... |
I will test this more thoroughly tomorrow when I have better access to a Windows computer. |
I was able to test with installing hdf5 version 1.14.2 using conda-forge and h5py 3.9.0 installed via pip. That combo fails ☹
|
This program returns that the filter is present in hdf5-feedstock. #include "hdf5.h"
#include <stdio.h>
int main() {
H5open();
printf("H5Z DEFLATE filter: %d\n", H5Zfilter_avail(1));
printf("H5Z SZIP filter: %d\n", H5Zfilter_avail(4));
return 0;
} h5py via pip is probably installing it's own wheel. The corresponding h5py rebuild seems to be failing due to Cython 3 issues. conda-forge/h5py-feedstock#130 I recommend closing this issue because the hdf5-feedstock is now fixed at 1.14.2. The issue is now with the h5py-feedstock. |
I just "worked around" the cython issues in h5py. Please try updating the conda stuff and report back. I don't have windows handy. |
Confirmed! it works on windows. Awesome effort guys! Thanks (★‿★) |
Solution to issue cannot be found in the documentation.
Issue
szip support was added with this pull request #198
However it stopped working with hdf5=1.14.1. See this discussion at the end of the pull request
#198 (comment)
Opening this issue to ask @mkitti to investigate.
Installed packages
Environment info
The text was updated successfully, but these errors were encountered: