Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbols on Windows #43

Open
pitrou opened this issue Mar 9, 2020 · 4 comments
Open

Missing symbols on Windows #43

pitrou opened this issue Mar 9, 2020 · 4 comments

Comments

@pitrou
Copy link
Member

pitrou commented Mar 9, 2020

gtest 1.8.1 was fine, but looks like 1.10.0 is missing some symbols in the Windows static lib:

unity_0_cxx.cxx.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static void __cdecl testing::Test::SetUpTestSuite(void)" (__imp_?SetUpTestSuite@Test@testing@@SAXXZ) referenced in function "public: static void (__cdecl*__cdecl testing::internal::SuiteApiResolver<class arrow::TypedTestBufferBuilder_AppendCopies_Test<short> >::GetSetUpCaseOrSuite(char const *,int))(void)" (?GetSetUpCaseOrSuite@?$SuiteApiResolver@V?$TypedTestBufferBuilder_AppendCopies_Test@F@arrow@@@internal@testing@@SAP6AXXZPEBDH@Z)
unity_0_cxx.cxx.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static void __cdecl testing::Test::TearDownTestSuite(void)" (__imp_?TearDownTestSuite@Test@testing@@SAXXZ) referenced in function "public: static void (__cdecl*__cdecl testing::internal::SuiteApiResolver<class arrow::TypedTestBufferBuilder_AppendCopies_Test<short> >::GetTearDownCaseOrSuite(char const *,int))(void)" (?GetTearDownCaseOrSuite@?$SuiteApiResolver@V?$TypedTestBufferBuilder_AppendCopies_Test@F@arrow@@@internal@testing@@SAP6AXXZPEBDH@Z)
release\arrow-buffer-test.exe : fatal error LNK1120: 2 unresolved externals

https://ci.appveyor.com/project/pitrou/arrow/builds/31348643/job/lja73rydw6cmwep4#L1073

@pitrou
Copy link
Member Author

pitrou commented Mar 9, 2020

Corresponding Arrow issue: https://issues.apache.org/jira/browse/ARROW-6941

@scopatz
Copy link
Member

scopatz commented Mar 9, 2020

A PR to fix this up would be amazing!

@wesm
Copy link
Member

wesm commented Mar 9, 2020

Seems conceivable that the underlying problem is in googletest itself

@jakirkham
Copy link
Member

Maybe raise an issue upstream then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants