Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential windows support #19

Closed
rsxdalv opened this issue Jul 19, 2023 · 6 comments
Closed

Potential windows support #19

rsxdalv opened this issue Jul 19, 2023 · 6 comments
Labels
question Further information is requested

Comments

@rsxdalv
Copy link

rsxdalv commented Jul 19, 2023

Comment:

I found this reply for building a wheel - microsoft/DeepSpeed#2427 (comment)

It's still far from a simple pipeline, but I was just curious to ask about the prospects of adding Windows to this conda package.

@rsxdalv rsxdalv added the question Further information is requested label Jul 19, 2023
@weiji14
Copy link
Member

weiji14 commented Oct 24, 2023

The main issue is that the conda-forge channel does not have Pytorch on Windows (see conda-forge/pytorch-cpu-feedstock#32), so we can't build a deepspeed package for Windows here.

You might be able to try using the pytorch channel (which does have Windows builds) to install pytorch (e.g. https://anaconda.org/pytorch/pytorch/files?version=2.1.0) + any other required dependencies, and then try pip install deepspeed, but not sure if that would work (haven't got a Windows computer to test). Mixing pytorch from the pytorch channel and deespeed from `conda-forge channel would most likely not work though. Another alternative is to try something like Windows Subsystem for Linux.

@rsxdalv
Copy link
Author

rsxdalv commented Oct 25, 2023

Thank you for the insight, sounds quite complicated to get this organized. Would you happen to know if the pytorch channel can be asked to add deepspeed? I couldn't find if they have a similar organization or repo on github to ask about this.

@weiji14
Copy link
Member

weiji14 commented Nov 5, 2023

Not sure if it's possible to add deepspeed to the pytorch channel since it's a third-party package, but you could try asking on the Pytorch forum, e.g. the Windows category at https://discuss.pytorch.org/c/windows/26?

@loadams
Copy link
Contributor

loadams commented May 28, 2024

Hi @weiji14 - we are working on this on the DeepSpeed side, support will get here after that is added and released.

@loadams loadams closed this as completed May 28, 2024
@rsxdalv
Copy link
Author

rsxdalv commented May 28, 2024

Hi @weiji14 - we are working on this on the DeepSpeed side, support will get here after that is added and released.

Thanks for the update! Is there an issue I can track to know when it's time to integrate it?

@loadams
Copy link
Contributor

loadams commented May 28, 2024

There are not any, there are a number of issues on the DeepSpeed side tracking this, but there will be an announcement when ready, and I'll update here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants