Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target libraries/executables to executable's RPATH #14

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

billysuh7
Copy link
Contributor

@billysuh7 billysuh7 commented Nov 4, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

xref: conda-forge/cuda-feedstock#10

Only libnvvp/nvvp binary executable needs patching here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7 billysuh7 marked this pull request as ready for review November 4, 2024 14:33
@billysuh7 billysuh7 requested a review from a team as a code owner November 4, 2024 14:33
@jakirkham
Copy link
Member

In the test phase on CI, this had a clobbering warning

ERROR:conda.stderr:
ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/linux-64::cuda-nvprof-12.6.80-hbd13f7d_0, local/linux-64::cuda-nvvp-12.6.80-hbd13f7d_1
  path: 'LICENSE'



done
Executing transaction: ...working... ERROR:conda.stderr:
ClobberWarning: Conda was asked to clobber an existing path.
  source path: /home/conda/feedstock_root/build_artifacts/pkg_cache/cuda-nvvp-12.6.80-hbd13f7d_1/LICENSE
  target path: /home/conda/feedstock_root/build_artifacts/cuda-nvvp_1730696031572/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/LICENSE



done

This may be nothing as it is talking about the license files clobbering, which doesn't make a lot of sense. So will try restarting. If we still see it, we may want to take a closer look

@jakirkham
Copy link
Member

@conda-forge-admin , please restart CI

@jakirkham
Copy link
Member

For some reason CI couldn't checkout the PR. Restarting again

@conda-forge-admin , please restart CI

@jakirkham
Copy link
Member

Going to try doing this manually

@jakirkham jakirkham closed this Nov 4, 2024
@jakirkham jakirkham reopened this Nov 4, 2024
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11673615986.

@jakirkham jakirkham closed this Nov 4, 2024
@jakirkham jakirkham reopened this Nov 4, 2024
@jakirkham
Copy link
Member

It seems CI is just misbehaving. To fix CI, we may need to try...

  1. Pushing additional commits to this PR
  2. Closing this PR and opening a new one

@billysuh7
Copy link
Contributor Author

In the test phase on CI, this had a clobbering warning

ERROR:conda.stderr:
ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/linux-64::cuda-nvprof-12.6.80-hbd13f7d_0, local/linux-64::cuda-nvvp-12.6.80-hbd13f7d_1
  path: 'LICENSE'



done
Executing transaction: ...working... ERROR:conda.stderr:
ClobberWarning: Conda was asked to clobber an existing path.
  source path: /home/conda/feedstock_root/build_artifacts/pkg_cache/cuda-nvvp-12.6.80-hbd13f7d_1/LICENSE
  target path: /home/conda/feedstock_root/build_artifacts/cuda-nvvp_1730696031572/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/LICENSE



done

This may be nothing as it is talking about the license files clobbering, which doesn't make a lot of sense. So will try restarting. If we still see it, we may want to take a closer look

I believe above is a legit warning but innocuous ? Both cuda-nvpp and cuda-nvprof contain LICENSE file at the root of their package ($PREFIX). I see that some feedstocks (like these) do not explicitly define files: section in which case all files from source tar seem to get packaged.

As a test I installed cuda-nvvp (the GA version of 12.6.80) and I see:

(test2) bsuh@cia-dev-bsuh-01:~/miniforge3/envs/test2$ conda list
# packages in environment at /home/bsuh/miniforge3/envs/test2:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       2_gnu    conda-forge
cuda-cupti                12.6.80              hbd13f7d_0    conda-forge
cuda-nvdisasm             12.6.77              hbd13f7d_0    conda-forge
cuda-nvprof               12.6.80              hbd13f7d_0    conda-forge
cuda-nvvp                 12.6.80              hbd13f7d_0    conda-forge
cuda-version              12.6                 h7480c83_3    conda-forge
libgcc                    14.2.0               h77fa898_1    conda-forge
libgomp                   14.2.0               h77fa898_1    conda-forge
libstdcxx                 14.2.0               hc0a3c3a_1    conda-forge
(test2) bsuh@cia-dev-bsuh-01:~/miniforge3/envs/test2$ ll
total 96
drwxrwxr-x  8 bsuh bsuh  4096 Nov  4 00:43 ./
drwxrwxr-x 20 bsuh bsuh  4096 Nov  5 14:42 ../
drwxrwxr-x  2 bsuh bsuh  4096 Nov  4 00:43 bin/
drwxrwxr-x  2 bsuh bsuh  4096 Nov  4 00:43 conda-meta/
drwxrwxr-x  3 bsuh bsuh  4096 Nov  4 00:43 lib/
drwxrwxr-x  7 bsuh bsuh  4096 Nov  4 00:43 libnvvp/
-rw-rw-r--  2 bsuh bsuh 63021 Oct  1 20:51 LICENSE
drwxrwxr-x  4 bsuh bsuh  4096 Nov  4 00:43 share/
drwxrwxr-x  3 bsuh bsuh  4096 Nov  4 00:43 targets/
(test2) bsuh@cia-dev-bsuh-01:~/miniforge3/envs/test2$ conda package -w LICENSE
LICENSE                                             conda-forge/linux-64::cuda-nvvp-12.6.80-hbd13f7d_0
LICENSE                                             conda-forge/linux-64::cuda-nvprof-12.6.80-hbd13f7d_0

@jakirkham
Copy link
Member

Thanks Billy! 🙏

As discussed yesterday, the clobbering warning is a real issue. However it is tangential to the issue we are solving here.

To follow up on clobbering, have filed upstream issue: conda-forge/cuda-feedstock#52

@jakirkham
Copy link
Member

Also noticed there was a second PR opened with these changes: #15

Did we want to stick with this PR or is there something else needed in that PR?

@billysuh7
Copy link
Contributor Author

Also noticed there was a second PR opened with these changes: #15

Did we want to stick with this PR or is there something else needed in that PR?

I just closed #15 :) I had opened it because this PR was broken but now it seems working now.

@jakirkham
Copy link
Member

Ah right the CI issues. Thanks Billy! 🙏

Ok let's get this in then

@jakirkham jakirkham merged commit ae30650 into conda-forge:main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants