Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib folders to executable's RPATH #14

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

billysuh7
Copy link
Contributor

@billysuh7 billysuh7 commented Oct 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Ran build locally and confirmed the RPATH:

$ patchelf --print-rpath cuda-cuxxfilt-12.6.77-hbd13f7d_0/bin/cu++filt
$ORIGIN/../lib:$ORIGIN/../targets/x86_64-linux/lib

xref: conda-forge/cuda-feedstock#10

@billysuh7 billysuh7 requested a review from a team as a code owner October 29, 2024 01:12
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

In this case, the executable is ./bin/cu++filt
@jakirkham
Copy link
Member

Thanks Billy! 🙏

Added a reference to issue ( conda-forge/cuda-feedstock#10 ) above. Please make sure other PRs related to that issue also have that link. This will help us keep track of which ones were done so we can ensure we have them all 🙂

@billysuh7
Copy link
Contributor Author

Thank you @jakirkham. I wonder why there is no check is being executed for linux-64/linux_aarch64/win-64 ?

@jakirkham
Copy link
Member

Let's try restarting

@conda-forge-admin , please restart CI

@jakirkham
Copy link
Member

Looks like it is now running

@jakirkham
Copy link
Member

Looks like we are seeing issue: conda-forge/status#188

Just need to wait for it to resolve and then restart

@billysuh7
Copy link
Contributor Author

@conda-forge-admin , please restart CI

@billysuh7 billysuh7 merged commit f27468b into conda-forge:main Oct 29, 2024
6 checks passed
@jakirkham
Copy link
Member

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants