Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target libraries to executable's RPATH #15

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Oct 15, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Partially addresses issue ( conda-forge/cuda-feedstock#10 )

@jakirkham
Copy link
Member Author

cc @billysuh7 (for awareness)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham jakirkham force-pushed the add_tgt_rpath_bin branch 3 times, most recently from 62215cc to 3ee1aa3 Compare October 15, 2024 23:14
@jakirkham jakirkham marked this pull request as ready for review November 8, 2024 23:21
@jakirkham jakirkham requested a review from a team as a code owner November 8, 2024 23:21
@jakirkham
Copy link
Member Author

Thanks Billy! 🙏

That change seems reasonable

Also looks like this is now passing

Please let me know if anything else is still needed here

Rebuild now that the RPATHs of the executables have been updated with
proper search locations.
Copy link
Contributor

@billysuh7 billysuh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakirkham
Copy link
Member Author

Thanks Billy! 🙏

@jakirkham jakirkham merged commit 608036b into conda-forge:main Nov 12, 2024
6 checks passed
@jakirkham jakirkham deleted the add_tgt_rpath_bin branch November 12, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants