-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop -ng
suffix for runtime libraries, but keep compat-wrappers
#148
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
|
This is ready now @conda-forge/ctng-compilers; I recommend to review commit by commit, the diff makes more sense that way. |
…nda-forge-pinning 2024.08.06.17.44.59
For some reason, ee7613f had fallen out of the last rebase - sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break all downstream recipes with error_overlinking: true
. Probably needs a run_exports
section in libgcc-ng
to fix that.
We also need to run a mini-migrator that changes
to
|
My plan was to update the compiler activation as well of course. I don't think many recipes depend directly on
Looking around, this only affects about 20 recipes. I think it would be less effort to fix them manually (I can do that) than write a migrator for all corner cases (and attach it to which migration...?). |
@isuruf, with the exception of ncurses & tzdata awaiting merge (and cuda-nvcc-impl/deno which need this PR), all buildable feedstocks (i.e non-failing CI) are now free of |
Co-authored-by: Isuru Fernando <[email protected]>
Avoid conflicts between new packages and older `-ng` builds with the same version; this commit can be reverted once we drop GCC 14 support. Co-authored-by: Isuru Fernando <[email protected]>
All good now? |
Thanks |
Hey @h-vetinari this seems to be causing clobbering between libgcc and libgcc-ng. Is this expected ? |
If we have an environment with just libgcc-ng 14.1.0 and no libgcc, when a user modifies the environment it results in libgcc 14.1.0 being added, with the warning:
|
Sorry about that. This shouldn't be possible based on the very tight run-constraints that we've added. Could you please open an issue with more details? |
This is a follow-up to a long-standing transition that has been in stasis. As noted in #134
The windows variants never introduced the suffix in the first place; drop it for the others too, but keep compatibility wrappers for a good while.