Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for metadata retrieval from GHCR.io #6

Merged
merged 15 commits into from
Apr 21, 2023
Merged

Add support for metadata retrieval from GHCR.io #6

merged 15 commits into from
Apr 21, 2023

Conversation

jaimergp
Copy link
Member

@beckermr
Copy link
Member

We'll need to add the OCI mirror package to conda.

@beckermr
Copy link
Member

You'll also need to change the code to use ruamel.yaml everywhere.

@jaimergp
Copy link
Member Author

Ugh I searched for pyyaml but of course the import name is just yaml 😬 I'll update!

This was referenced Apr 13, 2023
Merged
Closed
beckermr
beckermr requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaimergp I think for now since conda-oci-mirror is not on pypi and this package ships on both pypi and conda, we should make conda-oci-mirror optional. I have suggested changes to guard the import. All that is left is to make it optional in the pyproject.toml as well.

conda_forge_metadata/artifact_info/info_json.py Show resolved Hide resolved
conda_forge_metadata/artifact_info/info_json.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
beckermr
beckermr requested changes Apr 21, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

Weird test failure but the install appears to work.

@jaimergp
Copy link
Member Author

Ugh, that's the pre-commit thingy pyupgrading a bit too much. Let me check.

@jaimergp
Copy link
Member Author

There we go!

@beckermr beckermr merged commit 30222a9 into conda-forge:main Apr 21, 2023
@jaimergp jaimergp mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimergp @beckermr