Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-build v24.5.0 #225

Merged
merged 7 commits into from
May 13, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • frozendict
  • airflow

Packages found in the meta.yaml but not found by source code inspection:

  • chardet
  • conda-index
  • pytz
  • tqdm

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9021236944 - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting until Monday 5/13 to merge

@@ -130,3 +131,4 @@ extra:
- dbast
- jezdez
- kenodegard
- beeankha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beeankha guessing you are happy to be a maintainer here 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affirmative! 😄

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham
Copy link
Member

Waiting until Monday 5/13 to merge

Good idea

Hoping we still have a few folks around before PyCon starts

@beeankha beeankha mentioned this pull request May 10, 2024
31 tasks
Comment on lines -99 to -100
# bdist_conda
- python test_bdist_conda_setup.py bdist_conda --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom bdist_conda distutils/setuptools function was deprecated in 24.3.0 (see conda/conda-build#4985, conda/conda-build#5196) and removed in 24.5.0 (see conda/conda-build#5299)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change, @kenodegard ! Could you also please remove the recipe/test_bdist_conda_setup.py test file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops!

@beckermr beckermr requested a review from kenodegard May 13, 2024 16:27
@beckermr
Copy link
Member

@conda-forge/conda-build Shall we merge?

@beckermr
Copy link
Member

ok merging at the approval of two maintainers here. 🤞

@beckermr beckermr merged commit b5add61 into conda-forge:main May 13, 2024
37 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 24.5.0_h0c6ee7 branch May 13, 2024 19:31
@kenodegard kenodegard mentioned this pull request May 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants