Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_constrained field linking aiida-core & services versions #33

Closed
chrisjsewell opened this issue Jun 4, 2020 · 1 comment · Fixed by #34
Closed

Add run_constrained field linking aiida-core & services versions #33

chrisjsewell opened this issue Jun 4, 2020 · 1 comment · Fixed by #34

Comments

@chrisjsewell
Copy link
Contributor

chrisjsewell commented Jun 4, 2020

As discussed in aiidateam/aiida-core#4147 (comment),
Conda is really not happy trying to solve the environment for aiida-core + aiida-core.services.

Maybe a root issue here is that aiida-core and aiida-core.services are two completely separate packages, when really you want services to act like extra requirements do in setup.py, e.g. aiida-core[services].
Having a quick google, it might be good to add a https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run-constrained in the aiida-core package, to tie it to the same version of aiida-core.services i.e.:

requirements:
  run_constrained:
    - aiida-core.services =={{ version }}

which would constrain the possibilities for conda environment solving

@ltalirz
Copy link
Member

ltalirz commented Jun 4, 2020

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants