Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] toolset support for msvc compiler #10815

Closed
1 task done
MarcelRaad opened this issue Mar 17, 2022 · 6 comments · Fixed by #10808
Closed
1 task done

[suggestion] toolset support for msvc compiler #10815

MarcelRaad opened this issue Mar 17, 2022 · 6 comments · Fixed by #10808
Assignees
Milestone

Comments

@MarcelRaad
Copy link

Continuing from conan-io/tribe#32 (comment):

I'm currently using the non-default v141_xp and ClangCL toolsets with the Visual Studio compiler and the CMake and MSBuild build helpers from conans. I've just started trying to switch to the msvc compiler and the new build helpers from conan.tools. Unfortunately, I haven't found a way to specify a toolset there.

@memsharded
Copy link
Member

Hi @MarcelRaad

I have added support for _xp toolsets in #10808 for the msvc compiler.
It would be great if you could have a look, ideally running Conan from my PR source branch, and report.

Regarding ClangCL, that would need some more thinking, but I believe adding xp toolsets as a start sounds good.

@MarcelRaad
Copy link
Author

MarcelRaad commented Mar 18, 2022

Thanks, sounds good, I'll have a look! Might take me a while though as I'm not very familiar with Python development yet. (Edit: your README.rst is great though, so it will probably not take that long 👍 )

@memsharded
Copy link
Member

Thanks, sounds good, I'll have a look! Might take me a while though as I'm not very familiar with Python development yet. (Edit: your README.rst is great though, so it will probably not take that long 👍 )

Yes, the git clone + git checkout <branch> + pip install -e . works quite well. Looking forward your feedback!

@MarcelRaad
Copy link
Author

Tested with the new CMake build helper + Visual Studio 2022 (17.0) + v141_xp toolset and it works great. Thanks a lot! 👍

@memsharded
Copy link
Member

Excellent, thanks for the feedback @MarcelRaad !

@memsharded memsharded added this to the 1.47 milestone Mar 18, 2022
@memsharded
Copy link
Member

I am going to open a new issue for the clang toolsets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants