freeimage/3.18.0: fix build error using msvc 193 with C++20

[elvisdukaj]

Trying to build freeimage using MSVC 193 with C++20 results in a buid error. The issue was reported #18921.

I am creating a MR for this issue. I submitted also a MR upstream: issue and MR.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[uilianries]

Suggested change

	- patch_file: "patches/015_fix_msvc_cpp_20.patch"
	- patch_file: "patches/015_fix_msvc_cpp_20.patch"
	patch_type: "official"
	patch_source: "https://github.com/WinMerge/freeimage/pull/20"
	patch_description: "Fix compilation with MSVC and C++20"

Please, always add information about the patch, so we track it.

[uilianries]

Thank you for your quick response to this bug.

[uilianries]

@elvisdukaj Could you please ask for access in the issue #4. So the CI can list you as authorized user.

[jcar87]

Hi @elvisdukaj - thank you for your contribution and for looking into this.

Please note that your proposed patch WinMerge/freeimage#20 was not submitted to the canonical sources of freeimage, but to an unofficial clone.

Please submit or contact the maintainers at https://freeimage.sourceforge.io/.

Please note that we will not regularly accept patches fixing problems that are in library code - this should be reported and dealt with upstream. If this library is not maintained anymore, we will not be providing an extended life support in Conan Center. Remember that you can always instruct Conan to install a compatible version.

[elvisdukaj]

Hi @jcar87 thank you for your feedback!

Well if it’s not appropriate the patch in this context we can close this MR then. I’ll keep it only internally to my company! The project seems not maintained anymore indeed. I wasn’t aware that the GitHub wasn’t the official one 😞

[conan-center-bot]

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

[jcar87]

Well if it’s not appropriate the patch in this context we can close this MR then. I’ll keep it only internally to my company! The project seems not maintained anymore indeed. I wasn’t aware that the GitHub wasn’t the official one 😞

Thanks so much @elvisdukaj and thanks for your efforts! Keeping this internal is the way to go in these cases.
I will close the PR. We have no way of validating the proposed changes: they don't run on our CI, and we are not familiar with the codebase of this library to ascertain that this is compatible and working. For libraries that are no longer maintained by their authors, we will consider them unmaintained and won't be maintaining them ourselves either.

Thanks!

[thbeu]

As already mentioned in #18921 (comment), I do hope that there will be a v3.19.x at some time. See also danoli3/FreeImage#6.