From 2aa96784ec2b351208c6aae28c37fdd8eb72da1d Mon Sep 17 00:00:00 2001 From: Karthik99999 Date: Mon, 30 Sep 2024 11:44:10 -0700 Subject: [PATCH] fix: create PeerReviewer object in test mock data --- django/library/models.py | 2 +- django/library/tests/base.py | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/django/library/models.py b/django/library/models.py index e31acade9..bf91a6120 100644 --- a/django/library/models.py +++ b/django/library/models.py @@ -2334,7 +2334,7 @@ def decline(self): send_markdown_email( subject="Peer review: declined invitation to review model", template_name="library/review/email/review_invitation_declined.jinja", - context={"invitation": self}, + context={"invitation": self, "profile": self.reviewer.member_profile}, to=[settings.REVIEW_EDITOR_EMAIL], ) diff --git a/django/library/tests/base.py b/django/library/tests/base.py index 39c313100..055bbbe07 100644 --- a/django/library/tests/base.py +++ b/django/library/tests/base.py @@ -12,6 +12,7 @@ Contributor, PeerReviewInvitation, PeerReview, + PeerReviewer, ) from library.serializers import CodebaseSerializer @@ -136,7 +137,8 @@ def __init__(self, editor, reviewer, review): def get_default_data(self): return { - "candidate_reviewer": self.reviewer, + "candidate_reviewer": self.reviewer.member_profile, + "reviewer": self.reviewer, "editor": self.editor, "review": self.review, } @@ -155,7 +157,8 @@ class ReviewSetup: def setUpReviewData(cls): cls.user_factory = UserFactory() cls.editor = cls.user_factory.create().member_profile - cls.reviewer = cls.user_factory.create().member_profile + reviewer = cls.user_factory.create().member_profile + cls.reviewer = PeerReviewer.objects.create(member_profile=reviewer) cls.submitter = cls.user_factory.create() cls.codebase_factory = CodebaseFactory(cls.submitter)