Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository, or owner #42

Closed
ianstormtaylor opened this issue Jan 7, 2014 · 11 comments
Closed

repository, or owner #42

ianstormtaylor opened this issue Jan 7, 2014 · 11 comments

Comments

@ianstormtaylor
Copy link
Contributor

just a thought, the abbrev of repo seems unnecessary. repository would be nicer

actually, bigger picture, would it be better to just have an owner field instead of the duplication:

{
  "owner": "component",
  "name": "tip"
}
@jonathanong
Copy link
Contributor

+1

@visionmedia how were you planning on handling other sites like bit bucket?

@jonathanong
Copy link
Contributor

we shoudl also have a host flag or something defaulting to github. github: would be okay, but something like host: 'github' or host: 'github.com' would be good too

@jonathanong
Copy link
Contributor

Does this sound okay to you guys?

  • host defaulting to github
  • repository, which is short hand for <owner>-<repo>. i want to change it from repo since shorthands bother me. you guys okay with that?
  • name
  • owner, though i kind of prefer user and organization. should we alias them or just stick with owner?

@cristiandouce
Copy link

What's the deal with host? I mean... for what exactly would it be used for (and how)? Lookup or just meta data?

@jonathanong
Copy link
Contributor

If we ever support bit bucket, etc. we can scrape it for now

@ianstormtaylor
Copy link
Contributor Author

i think i'd be down to just go with repository and name to keep the transition simpler and mimic npm for everyone who knows it. we could then have "smart" expansions for repository to keep ourselves sane (unlike npm) so that component/dom works as expected and defaults to github?

@jonathanong what do you think of that?

basically it amounts to switching to the non abbreviated version and then just "specing" the acknowledgement that it expands to a git://github.com/REPO.git url internally

@cristiandouce
Copy link

I know. But let's say I have dependencies in a local component.json from both github and bitbucket. What I don't get is how would host key help resolve to install from github component/dom and from bitbucket cristiandouce/some-component ?

@jonathanong
Copy link
Contributor

repository and name to keep the transition simpler and mimic npm

yup i think i agree.

@cristiandouce i think it's more for discovery and such. right now, you would do remotes: ['github', 'bitbucket'] and it would search github, then bitbucket for every single dep.

@tj
Copy link

tj commented Mar 27, 2014

if we eventually support other end-points it probably makes more sense to start doing Go-style deps with the hostname included (even though it's ugly)

@jonathanong
Copy link
Contributor

is that full URLs? github.com/component/emitter?

i was thinking of a shortcut like github://component/emitter or something

@tj
Copy link

tj commented Mar 27, 2014

The cleanest would be if you could do github.com/component/emitter and there was a link rel= tarball link or something, that would be cool haha but since that will never happen and each needs magical support the scheme thing could work, and foo/bar could just remain as our opinionated GH thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants