Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

can't install components which has no component.json in the master branch #611

Closed
timaschew opened this issue Nov 22, 2014 · 3 comments
Closed

Comments

@timaschew
Copy link
Member

It's kind of opposite of #602
If you only have the component.json in a different branch than master
then component install doesn't work, example: https://github.com/timaschew/vexflow

Component should check all available semantic versions first, then install the latest or the given version.

@timaschew
Copy link
Member Author

It's the wrong order, see DEBUG:

remotes:github GET "https://raw.githubusercontent.com/component/emitter/master/component.json"
remotes:github GET "https://api.github.com/repos/component/emitter/tags"

@netpoetica
Copy link

Do you mean that if there is no component.json in master, we should checkout and look through all branches until we find the first branch that has one, and then use that component.json and install from master?

@timaschew
Copy link
Member Author

I mean we can fetch all tags for a repo (one request), then sort them and use the latest tag to check if there is a component json. If the latest tag doesn't contain a component.json then we don't check all other tags, instead we check the master branch (second request in this worst case).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants