Do not use complex typed static variables

[espakm]

The pythonqt.dll crashes when you try to load it dynamically on Windows. The crash happens at this point:

PythonQt/src/PythonQtConversion.h

Line 166 in 503597b

static void registerMetaTypeToPythonConverter(int metaTypeId, PythonQtConvertMetaTypeToPythonCB* cb) { _metaTypeToPythonConverters.insert(metaTypeId, cb); }

The static function refers to a static variable that has complex type (QHash). The static variable is not initialised.

The issue is described here:
http://stackoverflow.com/questions/5114683/loading-dll-not-initializing-static-c-classes
Basically, complex typed static variables should be avoided in dll-s.

Pull request follows. I tried to get rid of every references to complex typed static variables. The object typed (non pointer) static data members I replaced by static getters that declare the variable as pointer, assignes NULL to it, and then does a NULL check and assigns a 'new' instance at the first time.

There were many static locals declared with type QByteArray but used only as const char * later. I changed the types to 'const char *' wherever I could.

In other cases the static locals were used only as performance tweak. There, I simply removed the 'static' keyword. All of them were trivial functions, the 'static' keyword was not necessary and I doubt that it made noticeable difference in execution time.

[espakm]

#35

[jcfr]

Thanks for the PR 👍

I will have a look asap.

In the mean time, could you also discuss the issue on the PythonQt list ? See http://sourceforge.net/p/pythonqt/discussion/631392/

[espakm]

I opened this topic:

https://sourceforge.net/p/pythonqt/discussion/631392/thread/8b6e2e4a/

[jcfr]

Great. Thanks.