-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current issues with direct Nearby uploads #1329
Comments
Then we are done. Btw weird, I could upload as far as I remember. |
I think the crash was caused by re-loading the map after submitting the upload, since the line pointed to was a "IndexOutOfBounds" error at |
@neslihanturan I found a couple more issues. Sorry! :D |
@misaochan I will be looking at those issues today, can you write your new couple more issues too? |
I added them to the opening post yesterday already. Thanks! :) |
+1 Bug, if you click one of nearby markers and make information bottom sheet visible, then go to settings and change theme, app will crash when you re-start nearby activity. Editing first entry accordingly.
By the way, it doesn't crashes on orientation change anymore:/ maybe it was related with re-center button PR #1228 which is merged to another branch:/ |
[ 6 ] onStateChanged called with STATE_SETTLING then STATE_HIDDEN after changing theme ( Surrounding this line |
I think the list button can be made as a toggle to show list of nearby places on first click and hide them on second click |
I still get this crash when orientation changes when the options on nearby list is enabled |
I get this crash when internet is unavailable |
Thanks for your reports @97balakrishnan |
It is good to inform everyone interested to solve these bugs, please do not solve them before dNUnew branch is merged to master. @maskaravivek is working to rebase, after that we can send PRs related with these bugs. |
I am currently working on "internet unavailable crash", letting you know to prevent two persons working on the same issue. |
Ok I'll work on the text wrap issue after the branch is merged |
@97balakrishnan just setting singleLine=true on xml should work when it comes to text wrap problem. Or we can remove the text when there is no room . So we expect to see text when it fits. Note: Merge is done, you can send your PR |
Update: dnuNew is now merged with master. Moreover, @Jatin0312's recenter changes are also merged. Tests on master are still failing. :( |
@97balakrishnan after you saw that I was working on the internet thing and said "ok" , why did you create a related PR? We are not racing, we are colobrating please consider the comments next time... |
ok sorry :-) |
Thanks so much for working on this, guys! :) Just checking on our progress - which items have been solved? I guess 1, 3, 5 and 6 are done? |
I still get the below crash occasionally when I change orientation in Nearby, or sometimes even if I go to another activity and then return (e.g. uploading, or wikipedia, etc). It doesn't happen reliably, though.
|
I am not able to reproduce the error @misaochan :/ Besides I added one more issue on main list. Assigned 8 to myself. |
@neslihanturan I'll try to look into the crash in that case, you can focus on 8. :) |
I was about to propose myself for 8 too:) 9 is also assigned to me |
I will solve 6 tomorrow and we can make a bug free (at least known ones:)) release hopefully:) |
We are almost done, except one leak, leak A at #1368 |
Wonderful, great job @neslihanturan . :) Release will be coming up shortly! |
getting this exception on first time loading of nearby places after granting permission. |
Interesting, the directions symbol was never meant to be there. What happens when you select one of the pins and expand the bottom sheet? |
It remains there even if i select the pin and expand. Note: I got the directions symbol only after i zoomed the map. It was not initially present. |
Thanks @97balakrishnan . Could you create an issue for the problems you are experiencing, please? It would make it easier to organize the discussion. |
Ok sure |
Thanks! As the release has gone ahead, I will close this so we can have a fresh start on discussing existing issues at #1400 |
Summary:
I thought we should probably keep a list of issues we are experiencing with the directNearbyUploadsNew feature branch, so we don't miss anything out before releasing to production. Please feel free to edit this post to add issues or detail for issues.
Steps to reproduce:
Build from
2.7.x-release
and test the Nearby featureText wrap issues in bottom sheet (see SS below). I would recommend removing "Directions" textCrash on orientation changecrashes when list view is open and orinetation changed. PR: Fix IndexOutOfBounds exception in Nearby #1385Action bar is hiddenThe text was updated successfully, but these errors were encountered: