Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ghcjs support as experimental #4160

Conversation

matchwood
Copy link

Changes deprecation warning into experimental warning and makes relevant changes to documentation.

Fixes #4086 .

@matchwood matchwood changed the title Mark ghcjs support as experimental #4086 Mark ghcjs support as experimental Jul 17, 2018
### Recent versions of GHCJS, repacked for stack
### GHCJS repacked for snapsnots lts-8 and lts-9

Please see the [ghcjs-stack-dist repository](https://github.com/matchwood/ghcjs-stack-dist) for `lts-8` and `lts-9` configurations and refer to the [README](https://github.com/matchwood/ghcjs-stack-dist/blob/master/README.md) for common issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it we can't just have a table like for the earlier snapshots?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but I'd prefer people engaged with the README on the ghcjs-stack-dist repo (as there are some important issues flagged up there) and I didn't want to just copy across all that info. If and when we get a better story for ghcjs support I will rewrite the docs and put everything in a table etc.

@dbaynard dbaynard requested a review from bitemyapp July 17, 2018 11:54
@dbaynard
Copy link
Contributor

As @bitemyapp has just changed these files, I'm requesting a review from him — mainly to check there's nothing missing.

@dbaynard dbaynard merged commit b4ecafc into commercialhaskell:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants