-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open-source scripts that build docker images #624
Comments
We're planning to open this, but the current tool contains some proprietary information and needs refactoring to make it possible to extract that and release the non-proprietary parts as open source. |
@manny-fp thanks, good to know. We decided to search for less hardcode (in terms of infrastructure-change) ways for now, but I'll be watching this. |
👍 If I understand it correctly, I will need to copy the binary executable for |
Since the Docker integration can now use any image, custom images no longer need depend on the images FP Complete generates (see https://github.com/commercialhaskell/stack/blob/master/doc/docker_integration.md#custom-images). Therefore, reducing the priority of this issue. |
You mean, the actual docker images are built after adding some changes (by the proprietary tools) to https://github.com/commercialhaskell/stack/blob/a562702b3bcda71bc73663320a38e7cb937d1163/etc/docker/stack-base/Dockerfile ? |
How close is the linked dockerfile to the lts's? |
@kanishka-azimi: that Dockerfile is not related at all. I don't think that Dockerfile is actually used for anything and I'm going to remove it to avoid confusion. BTW I'm planning to open this up in the very near future. We're moving away from the current shake- and propellor- based process to build the images to a simplified one without any of the proprietary stuff, so it will just be a simple Dockerfile. |
The new scripts for LTS >= 8.0 are here: https://github.com/commercialhaskell/stack/tree/master/etc/dockerfiles/stack-build This is vastly simplified from the proprietary scripts we were using for LTS <= 7.x. Now we're only building the |
Please, open-source (or point me to) your work on building docker images with full stack packages built inside, so that any person could reproduce and/or customize it.
The text was updated successfully, but these errors were encountered: