Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Stack's integration tests not depend on $PATH #4468

Open
qrilka opened this issue Dec 27, 2018 · 6 comments
Open

Make Stack's integration tests not depend on $PATH #4468

qrilka opened this issue Dec 27, 2018 · 6 comments

Comments

@qrilka
Copy link
Contributor

qrilka commented Dec 27, 2018

While looking for a test covering problem resolved in #4467 I have found that our integration tests don't clean $PATH variable and thus could get run in an environment with some GHC being availble on user's path. It would be better if they were run in an "empty" environment probably with just Stack itself being available.
In my 1st attempt to do that I discovered that basic-install test appears to fail on my machine when $PATH environment variable gets deleted.
We need to find why this happens and check and fix problems with other tests.

@mihaimaruseac
Copy link
Contributor

Thank you for discovering this

@dbaynard
Copy link
Contributor

Test #4268 is related (see our discussion on #4407). With a clean path the test becomes trivial.

@mihaimaruseac
Copy link
Contributor

I think we can adapt the test to setup PATH properly before running (needs commenting out and issue created and then PR)

@dbaynard
Copy link
Contributor

dbaynard commented Feb 11, 2019

In my 1st attempt to do that I discovered that basic-install test appears to fail on my machine when $PATH environment variable gets deleted.

@qrilka Where is this branch? I'd like to see how you went about these changes. Thanks!

@qrilka
Copy link
Contributor Author

qrilka commented Feb 11, 2019

I think it was a (now deleted) branch for #4467 but if I remember it correctly you don't need a specific branch to see that effect

@dbaynard
Copy link
Contributor

Ah, thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants