Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle change tracking for pre-processor files / don't warn about them #3491

Closed
mgsloan opened this issue Oct 15, 2017 · 2 comments · Fixed by #5490
Closed

Handle change tracking for pre-processor files / don't warn about them #3491

mgsloan opened this issue Oct 15, 2017 · 2 comments · Fixed by #5490

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Oct 15, 2017

In #479 (comment) , warnings are emitted for modules that are defined via preprocessor. Since module name -> file path resolution is used for knowing when to rebuild, I think there is likely a rebuild issue here.

Not sure how to unambiguously resolve module names to files that do not have .hs or .lhs extensions, though. A hack could be to assume that it is the correct file if the name matches, ignoring the extension, and if it's listed in extra-source-files as suggested by the warning text. Currently it seems like extra-source-files is not taken into account here. So, either the warning text should be fixed or the behavior should make it so that its suggestion works.

Repro is at https://github.com/adituv/protobuf/tree/testpreprocess

@adituv
Copy link

adituv commented Oct 15, 2017

Perhaps there could be a stack.yaml field to list extensions there are custom preprocessors for?

@mgsloan
Copy link
Contributor Author

mgsloan commented Oct 15, 2017

Not a bad idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants