From f30d6ccf62ab9934a7a7226ae75a8ea722986c14 Mon Sep 17 00:00:00 2001 From: Kirill Zaborsky Date: Fri, 16 Nov 2018 12:53:37 +0300 Subject: [PATCH] Assum non-existing flags as errors This follows the changes appeared in #617 --- doc/build-overview.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/build-overview.md b/doc/build-overview.md index b1cc3e0a02..e42053168b 100644 --- a/doc/build-overview.md +++ b/doc/build-overview.md @@ -91,7 +91,8 @@ specific package) and _general_ (general option `*` for flags is only available snapshot packages that have been replaced. * Apply the `flags` and `ghc-options` by name to these packages overwriting any previous values coming from a snapshot. If any values are specified - but no matching package is found, it's an error. + but no matching package is found, it's an error. If a flag is not defined + in the corresponding package cabal file, it's an error. * We are now left with the following: * A wanted compiler version * A map from package name to immutable packages with package config (flags, GHC options, hidden) @@ -157,7 +158,9 @@ is found, it's an error. Note that flag settings are added _on top of_ previous settings in this case, and does not replace them. That is, if previously we have `singleton (FlagName "foo") True` and now add `singleton (FlagName "bar") True`, both `foo` and `bar` will now be -true. +true. If any flags are specified but no matching package is found, +it's an error. If a flag is not defined in the corresponding package +cabal file, it's an error. ## Apply CLI GHC options