Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Helmet generates a warning in development mode #27

Closed
gciotola opened this issue Nov 29, 2022 · 2 comments · Fixed by #28
Closed

React Helmet generates a warning in development mode #27

gciotola opened this issue Nov 29, 2022 · 2 comments · Fixed by #28

Comments

@gciotola
Copy link
Contributor

gciotola commented Nov 29, 2022

Starting from version 2.0.0 a warning is generated in development mode, when strict mode is on.

react-dom.development.js:86 Warning: Using UNSAFE_componentWillMount in strict mode is 
not recommended and may indicate bugs in your code

This comes from react-helmet. Original issue: nfl/react-helmet#548

We should migrate to react-helmet-async package since it seems to handle side effects in a better way

image

@gciotola
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gciotola
Copy link
Contributor Author

gciotola commented Dec 7, 2022

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant