Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: chainparams improvements #214

Open
nkostoulas opened this issue Sep 17, 2019 · 2 comments
Open

consensus: chainparams improvements #214

nkostoulas opened this issue Sep 17, 2019 · 2 comments
Labels
Type: Backport Type: Enhancement New feature or request
Milestone
Upstream

Comments

@nkostoulas
Copy link

nkostoulas commented Sep 17, 2019 •
edited
Loading

Should hardcode most of the config in chainparams ***Main classes post-mainnet. This way users don't have to depend on excessive and confusing config files. They should be able to connect only by specifying the "chain" name.
@nkostoulas nkostoulas added the Type: Enhancement New feature or request label Sep 17, 2019
@nkostoulas nkostoulas added this to the Mainnet milestone Sep 17, 2019
@nkostoulas
Copy link
Author

nkostoulas commented Sep 18, 2019 •
edited
Loading

Would be good to hardcode ports as well and use different ones for each.

Gold main default was 8443 and ocean main default 8332 but we are using 8332 for gold main now which might cause confusion.

@nkostoulas nkostoulas changed the title consensus: hardcode genesis config in chainparams consensus: chainparams improvements Oct 10, 2019
@nkostoulas
Copy link
Author

more ideas in https://github.com/ElementsProject/elements/blob/elements-0.14.1/src/chainparams.cpp

@nkostoulas nkostoulas modified the milestones: Mainnet, Upstream Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Backport Type: Enhancement New feature or request
Projects
None yet
Milestone
Upstream
Development

No branches or pull requests
1 participant
@nkostoulas