From 7982ca59ae9fb27bdcb956071d2c8c44e67e4469 Mon Sep 17 00:00:00 2001 From: nkostoulas Date: Fri, 25 Oct 2019 13:56:33 +0100 Subject: [PATCH] Logic bug causing misinformation when eth tx is null (node syncing) --- src/wallet/rpcwallet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index 7fa7f741b9..6622b0e242 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -5069,7 +5069,7 @@ UniValue validateethpegin(const JSONRPCRequest& request) pubKey.Decompress(); // eth addresses require full pubkey std::string strFailReason; - if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) && IsConfirmedEthPegin(tx, strFailReason)) { + if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) || !IsConfirmedEthPegin(tx, strFailReason)) { throw JSONRPCError(RPC_TRANSACTION_ERROR, strFailReason); } return true;