Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix option groups #575

Merged
merged 5 commits into from
Feb 2, 2020
Merged

Fix option groups #575

merged 5 commits into from
Feb 2, 2020

Conversation

hadzhiyski
Copy link
Contributor

  • Option groups take into account default value
  • Option groups can not be used with mutually exclusive set together
  • Multiple group errors are shown together

@hadzhiyski hadzhiyski mentioned this pull request Feb 2, 2020
Merged
@hadzhiyski hadzhiyski requested a review from moh-hassan February 2, 2020 16:31
@moh-hassan moh-hassan merged commit 32bbe00 into commandlineparser:develop Feb 2, 2020
@moh-hassan
Copy link
Collaborator

@hadzhiyski ,
I tried the attached project after merging
Default is working fine.
When group and setname are included in the option, I get an Exception "Operation not allowed". The details of error is included in the sample.
Can you check this case.

issues.zip

@moh-hassan
Copy link
Collaborator

I had fixed the Exception issue. No action is needed.
Thanks @hadzhiyski for the PR.

@hadzhiyski hadzhiyski deleted the fix/group-default-value branch February 3, 2020 08:08
moh-hassan added a commit that referenced this pull request Feb 3, 2020
@hadzhiyski @moh-hassan
Fix option groups (#575)
f8d2cee 
* Add MyGet package provider to consume the daily builds. (#566)

* Options groups take in account default value

* Do not allow options groups and exclusive set names to be used together

* Multiple group errors are shown together

* MissingGroupOptionError compare option names

Co-authored-by: Mohamed Hassan <[email protected]>
moh-hassan added a commit that referenced this pull request Feb 3, 2020
@hadzhiyski @moh-hassan
Fix option groups (#575)
8ee695e 
* Add MyGet package provider to consume the daily builds. (#566)

* Options groups take in account default value

* Do not allow options groups and exclusive set names to be used together

* Multiple group errors are shown together

* MissingGroupOptionError compare option names

Co-authored-by: Mohamed Hassan <[email protected]>
@moh-hassan moh-hassan added this to the 2.8 milestone Feb 19, 2020
moh-hassan added a commit that referenced this pull request Mar 11, 2020
@hadzhiyski @moh-hassan
Fix option groups (#575)
81dc3f2 
* Add MyGet package provider to consume the daily builds. (#566)

* Options groups take in account default value

* Do not allow options groups and exclusive set names to be used together

* Multiple group errors are shown together

* MissingGroupOptionError compare option names

Co-authored-by: Mohamed Hassan <[email protected]>
@jjzieve jjzieve mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moh-hassan moh-hassan Awaiting requested review from moh-hassan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@hadzhiyski @moh-hassan