Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge.py error in docker #29335

Closed
PenNameLuXun opened this issue Aug 11, 2023 · 4 comments · Fixed by #29343
Closed

bridge.py error in docker #29335

PenNameLuXun opened this issue Aug 11, 2023 · 4 comments · Fixed by #29343
Labels
PC Issues related to running openpilot on PC

Comments

@PenNameLuXun
Copy link

Describe the bug

root@docker-desktop:/openpilot/tools/sim# ./bridge.py
Traceback (most recent call last):
File "/openpilot/tools/sim/./bridge.py", line 25, in
from tools.sim.lib.can import can_function
File "/openpilot/tools/sim/lib/can.py", line 27, in
cp = get_car_can_parser()
^^^^^^^^^^^^^^^^^^^^
File "/openpilot/tools/sim/lib/can.py", line 26, in get_car_can_parser
return CANParser(dbc_f, signals, checks, 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "opendbc/can/parser_pyx.pyx", line 30, in opendbc.can.parser_pyx.CANParser.init
TypeError: init() takes at most 3 positional arguments (4 given)

my command is just follow https://github.com/commaai/openpilot/blob/master/tools/sim/README.md
when i run ./start_openpilot_docker.sh,the error happened.
anyone can help?plz.

OS Version

ubuntu22

openpilot version or commit

4cad0a0

Additional info

No response

@PenNameLuXun PenNameLuXun added the PC Issues related to running openpilot on PC label Aug 11, 2023
@bvss89
Copy link

bvss89 commented Aug 11, 2023

Same error for me as well. But running without docker.

@adeebshihadeh
Copy link
Contributor

@sshane can you fix? why didn't at least the linter catch this?

@sshane
Copy link
Contributor

sshane commented Aug 11, 2023

I couldn't find any way to do automatic function signature checking on imported Cython code, stubgen doesn't support it, and neither does pylint, ruff, or mypy that I could see. We can add manual stubs for the CANParser, but mypy doesn't check functions without typing so it would not have caught this.

@sshane sshane linked a pull request Aug 11, 2023 that will close this issue
@PenNameLuXun
Copy link
Author

It worked now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PC Issues related to running openpilot on PC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants