Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Simplify build script/process #268

Closed
thomaseizinger opened this issue Dec 7, 2019 · 2 comments
Closed

Simplify build script/process #268

thomaseizinger opened this issue Dec 7, 2019 · 2 comments
Assignees

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Dec 7, 2019

Problem

Currently, we have 2 feature flags and several conditional code paths to support windows or unix, depending on which platform we want to build for. This is because cargo does not support compiling a dependency with different features based on the target platform..

Goal

No feature-flags in our build process for support multiple platforms. cargo build should work on each platform (Linux, Windows, MacOS) and produce a binary that works.

Recommendation

I believe we might be able to fix some thing things downstream in the shiplift crate that would allow us to "just" depend on shiplfit and shiplift it self compiles according to the target platform without and special feature flags.

@bonomat

This comment has been minimized.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants