You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
No feature-flags in our build process for support multiple platforms. cargo build should work on each platform (Linux, Windows, MacOS) and produce a binary that works.
Recommendation
I believe we might be able to fix some thing things downstream in the shiplift crate that would allow us to "just" depend on shiplfit and shiplift it self compiles according to the target platform without and special feature flags.
The text was updated successfully, but these errors were encountered:
Problem
Currently, we have 2 feature flags and several conditional code paths to support windows or unix, depending on which platform we want to build for. This is because cargo does not support compiling a dependency with different features based on the target platform..
Goal
No feature-flags in our build process for support multiple platforms.
cargo build
should work on each platform (Linux, Windows, MacOS) and produce a binary that works.Recommendation
I believe we might be able to fix some thing things downstream in the
shiplift
crate that would allow us to "just" depend on shiplfit and shiplift it self compiles according to the target platform without and special feature flags.The text was updated successfully, but these errors were encountered: