Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: Add metric to measure how many times a tx was received #634

Closed
hvanz opened this issue Apr 3, 2023 · 0 comments · Fixed by #637
Closed

mempool: Add metric to measure how many times a tx was received #634

hvanz opened this issue Apr 3, 2023 · 0 comments · Fixed by #637
Assignees
Labels
enhancement New feature or request mempool metrics
Milestone

Comments

@hvanz
Copy link
Member

hvanz commented Apr 3, 2023

Feature Request

Related to #11. Prerequisite for #613.

Problem Definition

Currently transactions are propagated to all peers except to the peer that sent the transaction. Then a transaction may reach a node multiple times. A metric for counting the number a times a transaction was received by a node would help to improve the gossiping mechanism.

Proposal

Exposing one metric for each tx would add a huge number of Prometheus entries at each measurement. A better way would be to add a new metric of type histogram with sizes of buckets increasing exponentially. For example, buckets of size 1 (that is, number of transactions received at most once), 2, 4, 8, and more than 8.

@hvanz hvanz added enhancement New feature or request mempool metrics labels Apr 3, 2023
@hvanz hvanz added this to the 2023-Q2 milestone Apr 3, 2023
@hvanz hvanz self-assigned this Apr 3, 2023
@hvanz hvanz moved this from Todo to In Progress in CometBFT 2023 Apr 3, 2023
@hvanz hvanz moved this from In Progress to Ready for Review in CometBFT 2023 May 1, 2023
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in CometBFT 2023 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mempool metrics
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant