Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makefile so that make and make install only differ in copying the binary to GOPATH folder #128

Closed
merakrun opened this issue Feb 25, 2022 · 0 comments

Comments

@merakrun
Copy link

Currently, according to mainnet upgrade https://github.com/comdex-official/networks/blob/main/mainnet/01-upgrade-comdex-1.md should run make install

Usually, the behavior of make should be identical to make install but the binary installation path.

This allows users not using cosmovisor or building in another environment to examine the generated binary file BEFORE actually copying to target folder.

I would expect 'make' to build the binary correctly (currently it complains):

# github.com/comdex-official/comdex/testutil/network
testutil/network/network.go:60:23: cannot use baseapp.SetPruning("github.com/cosmos/cosmos-sdk/store/types".NewPruningOptionsFromString(val.AppConfig.BaseConfig.Pruning)) (type func(*baseapp.BaseApp)) as type []"github.com/CosmWasm/wasmd/x/wasm/keeper".Option in argument to app.New
# github.com/comdex-official/comdex/testutil/simapp
testutil/simapp/simapp.go:24:17: not enough arguments in call to app.New
        have ("github.com/tendermint/tendermint/libs/log".Logger, *db.MemDB, nil, bool, map[int64]bool, string, number, app.EncodingConfig, simapp.EmptyAppOptions)
        want ("github.com/tendermint/tendermint/libs/log".Logger, db.DB, io.Writer, bool, map[int64]bool, string, uint, app.EncodingConfig, "github.com/cosmos/cosmos-sdk/server/types".AppOptions, []"github.com/CosmWasm/wasmd/x/wasm/keeper".Option, ...func(*baseapp.BaseApp))
# github.com/comdex-official/comdex/x/oracle/keeper
x/oracle/keeper/query_server.go:77:15: Errorf format %d has arg req.Symbol of wrong type string
make: *** [Makefile:21: benchmark] Error 2

However... make install downloads additional modules and compilation succeeds and binary is copied to the GOPATH folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants