Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to change output name of ScalaJS bundle #496

Closed
gehnaphore opened this issue Dec 5, 2018 · 3 comments
Closed

Add setting to change output name of ScalaJS bundle #496

gehnaphore opened this issue Dec 5, 2018 · 3 comments
Labels
feedback wanted Additional feedback or testing is apreciated good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.
Milestone

Comments

@gehnaphore
Copy link
Contributor

The filename is important because the generated source map refers to it by that name.

@lefou lefou added the good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies. label Dec 6, 2018
@lefou
Copy link
Member

lefou commented Nov 22, 2022

Is this still valid? Don't we support something like modules which affect the output names? /cc @lolgab

@lefou lefou added the feedback wanted Additional feedback or testing is apreciated label Jan 18, 2023
@lihaoyi
Copy link
Member

lihaoyi commented Apr 23, 2023

This is now possible via def scalaJSOutputPatterns = OutputPatterns.fromJSFile("foo")

object foo extends ScalaJSModule {
  def scalaVersion = "2.13.8"
  def scalaJSVersion = "1.13.0"
  def ivyDeps = Agg(ivy"com.lihaoyi::scalatags::0.12.0")

  def scalaJSOutputPatterns = OutputPatterns.fromJSFile("foo")
}

@lihaoyi lihaoyi closed this as completed Apr 23, 2023
@lefou
Copy link
Member

lefou commented Apr 23, 2023

@lefou lefou added this to the 0.11.0-M2 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Additional feedback or testing is apreciated good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.
Projects
None yet
Development

No branches or pull requests

3 participants