We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation from Discord thread.
I started from the simple reproducible case (thanks @Baccata for raising) and tried some of the suggested changes in my mill fork.
In summary I understand there are two concerns:
implicit value for parameter tokensReader: mainargs.TokensReader[os.Path]
mainargs
The former works with adding import mill.runner.MillCliConfigParser.PathRead to MillBuildRootModule, but I didn't have luck with the latter.
import mill.runner.MillCliConfigParser.PathRead
MillBuildRootModule
I didn't raise a PR here with the changes as I suppose we don't want a custom TokensReader example (covered in mainargs readme).
The text was updated successfully, but these errors were encountered:
mainargs.TokensReader
Bundle Libraries
40b1920
Successfully merging a pull request may close this issue.
Continuation from Discord thread.
I started from the simple reproducible case (thanks @Baccata for raising) and tried some of the suggested changes in my mill fork.
In summary I understand there are two concerns:
implicit value for parameter tokensReader: mainargs.TokensReader[os.Path]
available by defaultmainargs
library provides a few readers (String, Boolean, Byte, etc.)The former works with adding
import mill.runner.MillCliConfigParser.PathRead
toMillBuildRootModule
, but I didn't have luck with the latter.I didn't raise a PR here with the changes as I suppose we don't want a custom TokensReader example (covered in mainargs readme).
The text was updated successfully, but these errors were encountered: