Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenAuthenticator should check canLogIn before actually logging in a user #52

Open
bummzack opened this issue Jul 15, 2015 · 3 comments
Open

TokenAuthenticator should check canLogIn before actually logging in a user #52

bummzack opened this issue Jul 15, 2015 · 3 comments

Comments

@bummzack
Copy link
Contributor

Member::canLogIn should be checked before logging in a user.

This will prevent that locked out users can login in any form.
@bummzack bummzack changed the title TokenAuthExtension should check canLogIn before actually logging in a user TokenAuthenticator should check canLogIn before actually logging in a user Jul 15, 2015
@bummzack
Copy link
Contributor Author

Should I create a PR for this?

@colymba
Copy link
Owner

colymba commented Jul 15, 2015

Yes please :) seems straightforward enough?

@bummzack
Copy link
Contributor Author

PR is up #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colymba @bummzack