Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TE-226 colour checker reference values. #901

Closed
KelSolaar opened this issue Nov 17, 2021 · 6 comments
Closed

Add TE-226 colour checker reference values. #901

KelSolaar opened this issue Nov 17, 2021 · 6 comments

Comments

@KelSolaar
Copy link
Member

References

@KelSolaar KelSolaar added this to the v0.4.0 milestone Nov 17, 2021
@Alt-Shivam
Copy link

Hey @KelSolaar sir
How to get started with this issue?
Can you help me out. :)

@KelSolaar KelSolaar modified the milestones: v0.4.0, v0.4.1, v0.4.2 Feb 19, 2022
@KelSolaar KelSolaar modified the milestones: v0.4.2, v0.4.3 Nov 27, 2022
@Rusching
Copy link
Contributor

Rusching commented Mar 1, 2023

Hi @KelSolaar I'd like to work on this issue, can you please give me more information on how to start it?

@KelSolaar
Copy link
Member Author

Hi @Rusching,

We would want to add the original CIE XYZ tristimulus values along with their converted CIE xyY counterpart in this module and expose it wherever relevant like the other color checkers: https://github.com/colour-science/colour/blob/develop/colour/characterisation/datasets/colour_checkers/chromaticity_coordinates.py

CCS_TE226_V2 is appropriate for a final name!

Cheers,

Thomas

@Rusching
Copy link
Contributor

Rusching commented Mar 2, 2023

Actually, TE226 has 45 colors while previous color checkers only contains 24. So should I add all these 45 colors?

@Rusching
Copy link
Contributor

Rusching commented Mar 2, 2023

Hope my operation process is correct, this is my first time to propose a formal PR ^^

@KelSolaar
Copy link
Member Author

Thank you!

@KelSolaar KelSolaar changed the title Add TE-226 reference values. Add TE-226 colour checker reference values. Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants