Why color space names with parentheses, e.g. "NTSC (1987)" cannot be plotted?

[yulincoder]

Description

When I type code following:

plot_RGB_chromaticities_in_chromaticity_diagram_CIE1931(
    [0.333, 0.333, 0.333],
    colourspaces=['sRGB', 'NTSC (1987)', 'Apple RGB'])

I can't get 'NTSC (1987)' graphics. And I traced the cause of this bug:
In the function of colour/utilities/common.py: def filter_mapping, colorspace name matching uses regular expressions re.match following：

        elements = [
            mapping[element]
            for element in mapping
            if re.match(filterer, element, flags)
        ]

Therefore, parentheses are treated as keywords of regular expressions.

Code for Reproduction

from colour.plotting import *
plot_RGB_chromaticities_in_chromaticity_diagram_CIE1931(
    [0.333, 0.333, 0.333],
    colourspaces=['sRGB', 'NTSC (1987)', 'Apple RGB'])

Exception Message

No response

Environment Information

colour-science: 0.4.1
Computer: macOS, Linux Mint

[KelSolaar]

Hi @yulincoder,

This is expected, the signature of the definition refers to the colour.plotting.common.filter_RGB_colourspaces definition which accepts Regex patterns. It wraps itself the colour.plotting.common.filter_passthrough definition that has the use case you gave above.

[yulincoder]

Ok, I see. I can use 'NTSC \(1953\)' to get the expected graphic.
And whether this rule can be explained in an obvious position? such as the top-level function. It really brings a lot of trouble.

[KelSolaar]

Next version of Colour will use a normal string so NTSC (1953) will work but also the new lower, slugified and canonical keys:

• ntsc (1953)
• ntsc-1953
• ntsc1953

Cheers,

Thomas

[yulincoder]

Thanks Thomas. 谢谢

[fredsavoir]

Thanks 🙏

…

Sent from my iPhone

On 27 Aug 2022, at 08:20, Thomas Mansencal ***@***.***> wrote:  Next version of Colour will use a normal string so NTSC (1953) will work but also the new lower, slugified and canonical keys: ntsc (1953) ntsc-1953 ntsc1953 Cheers, Thomas — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.