Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create job to send mass SMS notifications 👥 #472

Closed
Tracked by #473
tomas-salgado opened this issue Aug 23, 2024 · 15 comments · Fixed by #663
Closed
Tracked by #473

Create job to send mass SMS notifications 👥 #472

tomas-salgado opened this issue Aug 23, 2024 · 15 comments · Fixed by #663
Assignees
Labels
Backend 🔌 This requires backend work (ie: DB, business logic). Feature 🚀 A new feature or improvement.

Comments

@tomas-salgado
Copy link
Collaborator

tomas-salgado commented Aug 23, 2024

Description

We want to create a job that takes all the existing phone numbers in the database and sends a text notification utilizing Twilio.

Acceptance Criteria

  • The job should take in an array of phone numbers and a message
  • The job should send an SMS message to all phone numbers with the given message

Additional Context

We will want to add this code within a new directory named twilio within the path packages/core/src/modules.

This will be the first integration of Twilio with Oyster(!) so this will require some research-here are the Twilio docs. Feel free to check out the Slack use-cases to see examples of Slack jobs.

@tomas-salgado tomas-salgado added Feature 🚀 A new feature or improvement. Backend 🔌 This requires backend work (ie: DB, business logic). labels Aug 23, 2024
@Habeebah157
Copy link
Contributor

I would like to do this one.

@Habeebah157
Copy link
Contributor

Hello,
I am not sure if I am checking wrong but phone numbers would be under students right? Like the students numbers. I do it as one of the students fields. I also tried searching phone number in the codebase to give me a clue of what it could be but could not find it. There is nothing like phone number in the oyster channel on slack either.

@tomas-salgado
Copy link
Collaborator Author

Just left a comment about this in your Slack message, but basically PR is partly dependent on issue #477, since that issue will add the field phone_number to the database. While that is still in progress, you can add the field locally by adding the migration script here (which is from the PR that's up for issue #477).

@wflore19
Copy link
Contributor

Are there any updates on this issue @Habeebah157 ? I'd like to help

@Boris713
Copy link
Contributor

^^

@tomas-salgado
Copy link
Collaborator Author

Assigning this to @wflore19!

@wflore19
Copy link
Contributor

@Boris713 wanna pair program on this issue?

@Boris713
Copy link
Contributor

@wflore19 I'm down if you are

@wflore19
Copy link
Contributor

wflore19 commented Nov 29, 2024

@Boris713 Habeebah finished this issue and is submitting a pull request

@Habeebah157
Copy link
Contributor

What is it now, are you guys still doing it? Is it still assigned to me? I can still make a pull request right? Sorry I am just seeing this.

@tomas-salgado
Copy link
Collaborator Author

@Habeebah157 it seems like the others haven't started working on it. If you've already finished this feel free to put up your PR!

@Habeebah157
Copy link
Contributor

Usually how much time are we allowed to spend on an issue before it is transferred to someone else? I was not aware there was a time constraint or anything

@tomas-salgado
Copy link
Collaborator Author

tomas-salgado commented Nov 29, 2024

The ideal timeframe is about 3-4 weeks, after which the issue will be reassigned

@Habeebah157
Copy link
Contributor

Oh, ok. Thank you. I was not aware of that. Sorry it took so long. I will try to make a pull request asap

@Habeebah157
Copy link
Contributor

Hello, I had a problem with making a pull request and @wflore19 was able to help me solve it. I still have the code and all but I just want to let you guys know that it could take about a week to make another pull request because of my finals this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 🔌 This requires backend work (ie: DB, business logic). Feature 🚀 A new feature or improvement.
Projects
None yet
4 participants