Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support modular lists (via include directives) #769

Closed
mtxadmin opened this issue Apr 21, 2019 · 7 comments
Closed

support modular lists (via include directives) #769

mtxadmin opened this issue Apr 21, 2019 · 7 comments
Labels
directory-data changes to basic FilterLists data

Comments

@mtxadmin
Copy link
Contributor

Thanks for adding my list.

But it seems the engine does not support !#include tags (from uBlock Origin syntax). It looks only at root file with include sets and therefore incorrectly determines "Rule Count" numbers and "Updated" date.

@collinbarrett
Copy link
Owner

Hmm, the rule count and updated features are rough estimates and are only designed to be for a single list. We haven't really supported a list that is modular by design (that I can remember). Will have to think about this.

@collinbarrett collinbarrett changed the title support include tag add first-class support for modular lists (via include directives) Apr 21, 2019
@mtxadmin
Copy link
Contributor Author

It seems, include directive supported even by Adblock Plus now?

See @DandelionSprout 's list
https://github.com/DandelionSprout/adfilt/blob/master/a.txt :

[Adblock Plus 3.2]
! Title: 🏡 Imres filtre
! Version: 22April2019v5-Personal
! Expires: 12 hours
!#include a2.txt
!#include BrowseWebsitesWithoutLoggingIn.txt
!#include Anti-IMDB%20List.txt
.......

@DandelionSprout
Copy link
Contributor

I get the feeling that you (mtxadming) are misunderstanding. !#include remains unsupported by ABP, and the use of [Adblock Plus 3.2] instead of [Adblock Plus 2.0] is part of a one-man campaign of mine to intentionally break compatibility with low-quality AdBlock and ABP forks.

@mtxadmin
Copy link
Contributor Author

"one-man campaign" - sounds good :-)

I use uBlock last years so don't know about AdBlock Plus innovations. Thought I missed some.

@mtxadmin
Copy link
Contributor Author

(uBlock = uBlock Origin, of course)

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label May 4, 2019
@collinbarrett collinbarrett changed the title add first-class support for modular lists (via include directives) support modular lists (via include directives) Feb 17, 2020
@collinbarrett
Copy link
Owner

the rule count feature has been offline for sometime. I certainly hope to rebuild in the future, but I don't think this particular issue has a specific reason to remain open. closing for now.

@mtxadmin
Copy link
Contributor Author

It's a pity to hear that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

No branches or pull requests

3 participants