Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split Ultimate Hosts Blacklist Domains into segment ViewUrls #1293

Open
DandelionSprout opened this issue Jan 4, 2020 · 5 comments
Open
Labels
directory-data changes to basic FilterLists data

Comments

@DandelionSprout
Copy link
Contributor

DandelionSprout commented Jan 4, 2020

"Ultimate Hosts Blacklist - Domains" and "Ultimate Hosts Blacklist Domains" both have the canonical URL of https://filterlists.com/lists/ultimate-hosts-blacklist-domains, which lead to the information of the former. This makes it impossible to access the latter list's links through FilterLists.com.

Sure I was mostly just in need of accessing the latter list to see if they were duplicates of one another or not, but still.

@collinbarrett
Copy link
Owner

Hmm, yeah, the canonical link algorithm drops all special characters from the list title, so these two lists would be seen as duplicates.

The simplest solution would be if we verify whether these are duplicates or not. If they are, delete one or combine them somehow. If they aren't, maybe add the maintainer's name to the title or something to differentiate them.

Here are permalinks to the two in the data file so we can determine if they are duplicates.

@collinbarrett collinbarrett added bug something isn't working directory-data changes to basic FilterLists data web front-end user interface labels Jan 4, 2020
@DandelionSprout
Copy link
Contributor Author

Looking into the two lists for a few minutes, it seems to be Ultimate Hosts Blacklist - Domains that is the best version, surprisingly enough; as the other list randomly cuts off at O in its alphabetic order.

@collinbarrett
Copy link
Owner

Hmm, I think it's cuz the other one is split into three parts. https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/tree/master/domains

@collinbarrett
Copy link
Owner

collinbarrett commented Jan 4, 2020

related. #503

@collinbarrett collinbarrett removed bug something isn't working web front-end user interface labels Jan 4, 2020
@collinbarrett collinbarrett changed the title I found a bug in the canonical URLs for lists Fix bug in canonical URLs for Ultimate Hosts Blacklist Domains Feb 13, 2020
@collinbarrett collinbarrett changed the title Fix bug in canonical URLs for Ultimate Hosts Blacklist Domains fix bug in canonical URLs for Ultimate Hosts Blacklist Domains Feb 13, 2020
@collinbarrett collinbarrett added the feedback wanted provide your input label Feb 17, 2020
@collinbarrett collinbarrett changed the title fix bug in canonical URLs for Ultimate Hosts Blacklist Domains fix canonical URLs for Ultimate Hosts Blacklist Domains Feb 17, 2020
@collinbarrett
Copy link
Owner

#503 is resolved. one list can now be split across multiple ViewUrls by using the segmentNumber property in FilterListViewUrl.json

this is unblocked

@collinbarrett collinbarrett removed the feedback wanted provide your input label Sep 13, 2020
@collinbarrett collinbarrett changed the title fix canonical URLs for Ultimate Hosts Blacklist Domains split Ultimate Hosts Blacklist Domains into segment ViewUrls Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

No branches or pull requests

2 participants