Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and support Python 3.13 #723

Closed
1 of 2 tasks
niccokunzmann opened this issue Oct 12, 2024 · 8 comments · Fixed by #728
Closed
1 of 2 tasks

Test and support Python 3.13 #723

niccokunzmann opened this issue Oct 12, 2024 · 8 comments · Fixed by #728
Labels
doc good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/

Comments

@niccokunzmann
Copy link
Member

niccokunzmann commented Oct 12, 2024 •
edited
Loading

Python 3.13 has been released.

Please

  • add the Python version and tests
  • document which files to touch on a Python version change in the docs/maintenance section
@niccokunzmann niccokunzmann added doc good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ labels Oct 12, 2024
@mohammedfirdouss
Copy link
Contributor

@niccokunzmann Can I work on this issue, I would love to contribute

@niccokunzmann
Copy link
Member Author

@Firdous2307 thanks for asking and yes, please. On this repo, open a PR as soon as you have something and we can feedback and contribute.

@mohammedfirdouss
Copy link
Contributor

@niccokunzmann Thanks! I'll open a PR once I have the changes ready for your feedback

@mreguly mreguly mentioned this issue Oct 13, 2024
Merged
@mreguly
Copy link
Contributor

mreguly commented Oct 13, 2024

hey, I already submitted PR

@niccokunzmann niccokunzmann reopened this Oct 13, 2024
@niccokunzmann
Copy link
Member Author

@mreguly, thanks for doing the changes.

@Firdous2307 I left feedback on #728 for the changelog section and to complete this issue, the documentation would need changing so next time we remove or add a Python version, we know which files to touch. Would you like to do that?

@mohammedfirdouss
Copy link
Contributor

@niccokunzmann I had already made all my changes from start and included that part too.

@mohammedfirdouss mohammedfirdouss mentioned this issue Oct 13, 2024
Merged
2 tasks
@mohammedfirdouss
Copy link
Contributor

mohammedfirdouss commented Oct 13, 2024 •
edited
Loading

@niccokunzmann I have fixed the changelog

@niccokunzmann
Copy link
Member Author

@Firdous2307 @mreguly thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test python 3.13 support mreguly/icalendar
3 participants
@niccokunzmann @mreguly @mohammedfirdouss