Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Related Transactions #74

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

varunpcb
Copy link
Contributor

@varunpcb varunpcb commented Jan 6, 2021

Motivation

Adds support for the planned related transaction feature that will allow linking of multiple transactions within rosetta.

Solution

Transactions will now feature an optional related_transactions array of RelatedTransaction objects. Related Transaction objects feature a network_identifier (optional), transaction_identifier, and direction (forward or backward). This was done to provide support for multiple relations of different directions across multiple networks if necessary.

Changes

  • Update version to 1.4.10
  • Add Related Transaction model
  • Add Direction enum
  • Update Transaction model with Related Transactions field

Open questions

N/A

@patrick-ogrady patrick-ogrady changed the title add modeling for related transactions Add modeling for related transactions Jan 6, 2021
@patrick-ogrady patrick-ogrady changed the title Add modeling for related transactions Add Support for Related Transactions Jan 6, 2021
@varunpcb varunpcb closed this Jan 6, 2021
@varunpcb varunpcb reopened this Jan 6, 2021
@varunpcb varunpcb closed this Jan 6, 2021
@varunpcb varunpcb reopened this Jan 6, 2021
@varunpcb varunpcb closed this Jan 6, 2021
@varunpcb varunpcb reopened this Jan 6, 2021
@patrick-ogrady patrick-ogrady merged commit c820407 into coinbase:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants